-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow 5000 rows #80
base: main
Are you sure you want to change the base?
allow 5000 rows #80
Conversation
WalkthroughThe recent changes involve adjusting the row limit check for datasets from 1000 to 5000, updating error messages accordingly, and incrementing the project version in the Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
athina/datasets/dataset.py (1)
Line range hint
61-61
: Consider removing unused exception variable.The variable
e
is declared but never used, which could be cleaned up to enhance code clarity.- except Exception as e: + except Exception: raiseAlso applies to: 90-90
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- athina/datasets/dataset.py (1 hunks)
- examples/dataset_creation.ipynb (1 hunks)
- pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (2)
- examples/dataset_creation.ipynb
- pyproject.toml
Additional context used
Ruff
athina/datasets/dataset.py
61-61: Local variable
e
is assigned to but never used (F841)Remove assignment to unused variable
e
90-90: Local variable
e
is assigned to but never used (F841)Remove assignment to unused variable
e
Additional comments not posted (4)
athina/datasets/dataset.py (4)
83-83
: Updated row limit to 5000 approved.The change in the row limit from 1000 to 5000 is reflected in the exception message correctly.
Line range hint
33-59
: Methodcreate
looks well-implemented.The method handles dataset creation with appropriate error handling and data filtering. No changes are necessary here.
Line range hint
96-101
: Methodfetch_dataset_rows
is correctly implemented.This method efficiently fetches dataset rows and handles optional limits on the number of rows.
Line range hint
103-105
: Methoddataset_link
functions as expected.This utility method correctly constructs and returns a dataset link.
Summary by CodeRabbit
New Features
Documentation
Chores